fix the return type ) #632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtticusZeller
requested review from
olirice,
J0 and
silentworks
as code owners
|
Makes sense, tallies with what's on postgrest-py. Thanks for the PR @Atticuszz Mind running the pre-commit hook? Can approve after |
# Conflicts: # supabase/_async/client.py
thanks ，it's my first time PR,i done the run pre-commmit and will remeber to run pre-commit from now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
update the return type in async _client def rpc(self, fn: str, params: Dict[Any, Any])->
from AsyncFilterRequestBuilder: to AsyncRPCFilterRequestBuilder[Any]:
Bug fix, feature, docs update, ...
What is the new behavior?
None just type hint
Feel free to include screenshots if it includes visual changes.