Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs (sunbase-py) updated setup instructions, PR guidelines, added resources & links #690

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

brielle5810
Copy link
Contributor

What kind of change does this PR introduce?

Docs update:

  • Added more setup instructions and resources (linked) for Python, conda, and poetry
  • Added links to mentioned community spaces (Discord, Discussions tab)
  • Specified guidelines for filing issues and requests
  • Gave instructions on linking issues/PRs
  • Changed README structure to avoid repetition of added information

What is the current behavior?

Missing potentially helpful information for new contributors.

What is the new behavior?

Improved the onboarding experience for new contributors by including more relevant and helpful information/instructions, resources, and guidelines.

Additional context

N/A

Added setup instructions and resources, links to community spaces, specified issue and request guidelines, gave instructions on linking issues/PRs
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Documentation

PR Summary: This pull request introduces a comprehensive update to the documentation, aimed at improving the onboarding experience for new contributors. It includes detailed setup instructions for a local development environment, links to relevant resources for Python, conda, and poetry, and guidelines for contributing, such as how to file issues and feature requests, and how to link issues or PRs in descriptions. The changes are designed to make the repository more accessible and to streamline the contribution process.

Decision: Comment

📝 Type: 'Documentation' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Consider integrating direct links to external resources (e.g., poetry and conda documentation) within the text where these tools are first mentioned to provide immediate access and improve the user experience.
  • Review the document for typographical errors to maintain professionalism and clarity in the documentation. For example, correcting 'deature requests' to 'feature requests'.
  • Ensure consistency in verb-subject agreement within the documentation to enhance readability. For instance, changing 'are' to 'is' in the context of contributing to the Python libraries.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Fixed a typo of the word feature
README.md Outdated Show resolved Hide resolved
Changed GitHub Discussions link to the main Github discussions since the other will be discontinued
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13bed26) 44.17% compared to head (b2f57a1) 44.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #690   +/-   ##
=======================================
  Coverage   44.17%   44.17%           
=======================================
  Files          13       13           
  Lines         326      326           
=======================================
  Hits          144      144           
  Misses        182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silentworks silentworks merged commit 846d8e7 into supabase:main Feb 15, 2024
7 checks passed
@silentworks
Copy link
Contributor

@brielle5810 Thank you for your contribution in making this project better for everyone wanting to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants