Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated package configurations to use hatch #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alon-david
Copy link
Contributor

hey hey,
I've migrated our build system to use hatch.
it's a swiss army knife of the python build system.. :)

for versioning..
image

@idanasulin2706
Copy link
Contributor

Thanks for this one, we will look into it and will update

@valeraBr
Copy link
Contributor

Hi @alon-david ,

I went through the PR and you did really awesome work, looks very elegant and readable!
One thing that we need to change is the versioning process. Is it possible to use the version.conf file in this case? We need it there to align with the rest of our repositories for the internal version process.

@alon-david alon-david force-pushed the feature/hatch-based branch 2 times, most recently from bdfddcb to 7180ec4 Compare February 28, 2023 15:06
@alon-david
Copy link
Contributor Author

Hi @alon-david ,

I went through the PR and you did really awesome work, looks very elegant and readable! One thing that we need to change is the versioning process. Is it possible to use the version.conf file in this case? We need it there to align with the rest of our repositories for the internal version process.

fixed.
take a look for best compatibility with hatch version pattern, we should quote the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants