Combined improvements and fixes #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo that causes a crash if called.
In __verify_command the source.lower() is used, so everything in the sources must also be lower or it will never match.
In addition to the existing method that returns the bit field, return a dictionary with descriptive values, similar to mem_oom() and mem_reloc_stats().
Added a simple helper function that prints out all the relevant details. Set it to be what runs from main with a `python3 -m vcgencmd` call.
There were a couple that uncovered bugs, they are marked TODO
Included whitespace in the split so that it would only pickup the column separated key/value pairs. This fixes the bug where the `mmal-opaque` key was getting chopped up.
It appears that the string could be "720 480 24\n" or "0 0 0 no display\n". Splitting on any whitespace (default) handles both.
GitHub action test
|
@sushantnadkar Do you have any interest in pulling in these changes and releasing a new version to pypi? If not, I can create my own package there with a different name. If you're interested but just busy, no rush, just let me know please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several bugs, add unit testing, add summary output, descriptive throttled output.
This combines several of the other branches/pull requests into one.