Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit Fix for kepler 1341 #150

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

SamYuan1990
Copy link
Contributor

Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990 SamYuan1990 requested review from rootfs and jichenjc April 19, 2024 12:30
@juangascon
Copy link

juangascon commented Apr 22, 2024

@SamYuan1990
Thanks for doing the pull request on my behalf. I had some personal issues to manage and could not propose the pull request.
Though, I see in the commit that we are only changing the 'code' block but not the line number 28 explaining the code.
We should also modify it from
To deploy on a local kind cluster, you need to use the CI_DEPLOY and PROMETHEUS_DEPLOY flags.
to
To deploy on a local kind cluster, you need to use the PROMETHEUS_DEPLOY flag.
I could propose a pull request but I do not know if it is going to mess up if I create it before this commit is merged.

Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
Copy link
Contributor Author

@SamYuan1990 Thanks for doing the pull request on my behalf. I had some personal issues to manage and could not propose the pull request. Though, I see in the commit that we are only changing the 'code' block but not the line number 28 explaining the code. We should also modify it from To deploy on a local kind cluster, you need to use the CI_DEPLOY and PROMETHEUS_DEPLOY flags. to To deploy on a local kind cluster, you need to use the PROMETHEUS_DEPLOY flag. I could propose a pull request but I do not know if it is going to mess up if I create it before this commit is merged.

good catch, updated, please help review.

@jichenjc
Copy link
Contributor

don't know whether we need squash the commits
the change is good to me

@rootfs rootfs merged commit 1c7e305 into sustainable-computing-io:main Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kepler in Kind - Wrong OPTS for building manifest
4 participants