fix: disable monitoring by default

Signed-off-by: Sunil Thaha <sthaha@redhat.com>

.github/workflows/pr-checks.yaml

@@ -155,7 +155,7 @@ jobs:
           local_dev_cluster_version: v0.0.4
         env:
           # NOTE: prometheus is required since operator installs ServiceMonitor
-          PROMETHEUS_ENABLE: "true"
+          PROMETHEUS_ENABLE: "false"
 
       - name: Ensure cluster is able to run OLM bundles
         run: make cluster-prereqs

Makefile

@@ -117,14 +117,16 @@ docs: crdoc manifests ## Generate docs.
 ##@ Development env
 CLUSTER_PROVIDER ?= kind
 LOCAL_DEV_CLUSTER_VERSION ?= main
-GRAFANA_ENABLE ?= true
+GRAFANA_ENABLE ?= false
+PROMETHEUS_ENABLE ?= false
 KIND_WORKER_NODES ?=2
 
 .PHONY: cluster-up
 cluster-up: ## setup a cluster for local development
 	CLUSTER_PROVIDER=$(CLUSTER_PROVIDER) \
 	VERSION=$(LOCAL_DEV_CLUSTER_VERSION) \
 	GRAFANA_ENABLE=$(GRAFANA_ENABLE) \
+	PROMETHEUS_ENABLE=$(PROMETHEUS_ENABLE) \
 	KIND_WORKER_NODES=$(KIND_WORKER_NODES) \
 	./hack/cluster.sh up
 
@@ -137,6 +139,7 @@ cluster-restart: ## restart the local development cluster
 	CLUSTER_PROVIDER=$(CLUSTER_PROVIDER) \
 	VERSION=$(LOCAL_DEV_CLUSTER_VERSION) \
 	GRAFANA_ENABLE=$(GRAFANA_ENABLE) \
+	PROMETHEUS_ENABLE=$(PROMETHEUS_ENABLE) \
 	KIND_WORKER_NODES=$(KIND_WORKER_NODES) \
 	./hack/cluster.sh restart
 

hack/cluster.sh

@@ -22,7 +22,8 @@ set -eu -o pipefail
 # config
 declare -r VERSION=${VERSION:-v0.0.3}
 declare -r CLUSTER_PROVIDER=${CLUSTER_PROVIDER:-kind}
-declare -r GRAFANA_ENABLE=${GRAFANA_ENABLE:-true}
+declare -r GRAFANA_ENABLE=${GRAFANA_ENABLE:-false}
+declare -r PROMETHEUS_ENABLE=${PROMETHEUS_ENABLE:-false}
 declare -r KIND_WORKER_NODES=${KIND_WORKER_NODES:-2}
 
 # constants
@@ -63,7 +64,7 @@ git_checkout() {
 }
 
 cluster_prereqs() {
-	info "setting up SCC crd"
+	info "setting up external CRDs used by the operator"
 	kubectl apply --force -f "$PROJECT_ROOT/hack/crds"
 
 	kubectl get catalogsource && {
@@ -120,6 +121,7 @@ main() {
 	git_checkout
 	export CLUSTER_PROVIDER
 	export GRAFANA_ENABLE
+	export PROMETHEUS_ENABLE
 	export KIND_WORKER_NODES
 	cd "$DEV_CLUSTER_DIR"
 	"$DEV_CLUSTER_DIR/main.sh" "$op"