fix: deletion error when deleting dashboard configmaps #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes following reconcilation error when deleting dashboards
installed to `openshift-config-managed` namespace.
```
continue reconciliation despite error {"name":"kepler", "error": "power-monitoring-overview (/v1, Kind=ConfigMap): deleter: timed out waiting for deletion : timed out waiting for the condition"}
continue reconciliation despite error {"name":"kepler", "error": "power-monitoring-by-ns (/v1, Kind=ConfigMap): deleter: timed out waiting for deletion : timed out waiting for the condition"}
finalizer state {"name":"kepler", "reconciler": "finalizer", "deleted": true, "finalizer": true}
2023-10-06T08:24:03Z ERROR Reconciler error {"controller": "kepler", "controllerGroup": "kepler.system.sustainable.computing.io", "controllerKind": "Kepler", "Kepler": {"name":"kepler"}, "namespace": "", "name": "kepler", "reconcileID": "514af8c3-7d06-4dde-ac80-daffd24c5138", "error": "power-monitoring-by-ns (/v1, Kind=ConfigMap): deleter: timed out waiting for deletion : timed out waiting for the condition"}
```
The error occurs because the client does not cache objects in `openshift-config-managed`
namespace, which this commit fixes
Fixes: sustainable-computing-io#271
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
(cherry picked from commit c8a68a7acdda7d35d9bfd6f3e8a124320e0baef2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes following reconcilation error when deleting dashboards installed to
openshift-config-managednamespace.The error occurs because the client does not cache objects in
openshift-config-managednamespace, which this commit fixesFixes: #271
Signed-off-by: Sunil Thaha sthaha@redhat.com