feat(ci): add support to cache tools in CI #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com>
sthaha
reviewed
Oct 17, 2023
| @@ -38,6 +38,9 @@ runs: | |||
| username: ${{ inputs.registry_login }} | |||
| password: ${{ inputs.registry_token }} | |||
|
|
|||
| - name: Install all tools | |||
| uses: ./.github/tools-cache | |||
There was a problem hiding this comment.
Just a thought, perhaps we should move all actions to actions
sthaha
reviewed
Oct 17, 2023
| id: tools-cache | ||
| with: | ||
| path: ./tmp/bin | ||
| key: ${{ runner.os }}-tools-${{ hashFiles('./.github/tools-cache') }} |
There was a problem hiding this comment.
We need to may be hash hack/tools.sh instead. What ObO does is to create a '.github/tools` file see: https://github.com/rhobs/observability-operator/blob/main/.github/tools
The hash of that file is used to check of new binaries need to be downloaded.
sthaha
requested changes
Oct 17, 2023
|
@vprashar2929 this got closed automatically because the branch was deleted. Can you please create a PR from your fork? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #203
CI runs:
Cache: https://github.com/vprashar2929/kepler-operator/actions/caches
Install tools: https://github.com/vprashar2929/kepler-operator/actions/runs/6529594381/job/17727500939#step:4:6
Sample run: https://github.com/vprashar2929/kepler-operator/actions/runs/6529594381