fix(test): export KUBECONFIG to oc only if set #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when KUBECONFIG is not set, instead of oc defaulting to
~/.kube/config, it uses KUBECONFIG that points no where and tests fail
as follows:
```
❯ go test -v ./tests/e2e/... -run Node -count=1 -timeout=15m
=== RUN TestNodeSelector
Running command cmd oc args [get node -o jsonpath={.items[*].metadata.name}]
kepler_test.go:90:
Error: Received unexpected error: exit status 1
Messages: failed to get node names
kepler_test.go:91:
Error: Should not be zero, but was 0
Messages: got zero nodes
--- FAIL: TestNodeSelector (0.08s)
panic: runtime error: index out of range [0] with length 0 [recovered]
panic: runtime error: index out of range [0] with length 0
```
This commit fixes the issue by exporting KUBECONFIG only if it is
not empty.
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when KUBECONFIG is not set, instead of oc defaulting to ~/.kube/config, it uses KUBECONFIG that points no where and tests fail as follows:
This commit fixes the issue by exporting KUBECONFIG only if it is not empty.