Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use Kepler annotation to choose bcc or libbpf kepler image #293

Merged

Conversation

vimalk78
Copy link
Collaborator

This PR reads value of annotation "app.kubernetes.io/kepler-bpf-attach-method" on Kepler object to decide which bpf type image to be deployed.
If the value is "libbpf" , the image quay.io/sustainable_computing_io/kepler:release-0.6.1-libbpf is chosen, else quay.io/sustainable_computing_io/kepler:release-0.6.1 is used.

This is a temporary fix to let users choose libbpf image till kepler upstream makes libbpf as the default attach method.

fixes: https://issues.redhat.com/browse/POWERMON-166

Signed-off-by: Vimal Kumar <vimal78@gmail.com>
@sthaha sthaha merged commit ebab25b into sustainable-computing-io:v1alpha1 Oct 26, 2023
@BGrasnick
Copy link
Contributor

This is great, thank you @vimalk78 @sthaha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants