test: improve e2e test script #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthaha
force-pushed
the
feat-improve-e2e-script
branch
7 times, most recently
from
cec51a3 to
a7ba7e1
Compare
sthaha
force-pushed
the
feat-improve-e2e-script
branch
2 times, most recently
from
5bae3e7 to
50c63ab
Compare
vprashar2929
reviewed
Dec 6, 2023
vprashar2929
reviewed
Dec 6, 2023
vprashar2929
reviewed
Dec 6, 2023
| @@ -87,13 +142,23 @@ install_operator-sdk() { | |||
| ok "operator-sdk was installed successfully" | |||
| } | |||
|
|
|||
| version_govulncheck() { | |||
| warn govulncheck - latest | |||
There was a problem hiding this comment.
This shouldn't be warn right?
There was a problem hiding this comment.
it should be warn because the version isn't pinned.
vprashar2929
reviewed
Dec 6, 2023
vprashar2929
reviewed
Dec 6, 2023
sthaha
force-pushed
the
feat-improve-e2e-script
branch
from
50c63ab to
956e663
Compare
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
sthaha
force-pushed
the
feat-improve-e2e-script
branch
2 times, most recently
from
6e92cf1 to
c30f489
Compare
|
/lgtm |
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
sthaha
force-pushed
the
feat-improve-e2e-script
branch
from
c30f489 to
aa5a84c
Compare
vprashar2929
merged commit 07e5b38
into
sustainable-computing-io:v1alpha1
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes
go testso that accidental edits togo test ...can be avoided. Eg.gThis skips operator deployment (only restarts the already running operator) and runs only
Nodetest.