POWERMON-199: Use correct kepler namespace in must-gather #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimalk78
force-pushed
the
fix-must-gather-ns
branch
from
8a7417b to
22fec3d
Compare
sthaha
reviewed
Jan 28, 2024
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| set -eu -o pipefail | |||
|
|
|||
| export KEPLER_NS="kepler-operator" | |||
| export KEPLER_NS=$(oc get ns -l app.kubernetes.io/managed-by=kepler-operator --output=jsonpath='{.items[*].metadata.name}') | |||
There was a problem hiding this comment.
perhaps only the first item instead of all items in the list?
jsonpath={.items[0].metadata.name} ?
There was a problem hiding this comment.
ideally there should be only 1.
There was a problem hiding this comment.
yes, indeed .. already approved.
In a different PR, I think it is better to iterate on all namespaces to capture the details. That way we get all namespaces (perhaps user has both community and power-mon installed) etc ...
|
On a related topic, perhaps |
sthaha
approved these changes
Jan 29, 2024
Signed-off-by: Vimal Kumar <vimal78@gmail.com>
sthaha
force-pushed
the
fix-must-gather-ns
branch
from
22fec3d to
34c9aba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use labels to get correct namespace name.