Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POWERMON-199: fix gather power-monitoring-operator info #353

Merged

Conversation

vimalk78
Copy link
Collaborator

fix gather power-monitoring-operator info

@vimalk78 vimalk78 requested a review from vprashar2929 January 29, 2024 13:21
@vimalk78 vimalk78 force-pushed the fix-must-gather-ns-1 branch from 6e7dca2 to 6e82190 Compare January 29, 2024 13:28
Comment on lines +27 to +29
get_catalogsource() {
log "getting catalogsource info for kepler-operator"
run oc -n "$KEPLER_OPERATOR_NS" get catalogsource kepler-operator-catalog -oyaml "$POWER_MONITORING_OPERATOR_INFO_DIR/kepler-operator-catalogsource.yaml"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove this as the operator would be from Red Hat certified Operators catalog source right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kept it for community operator

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but gather-power-monitoring-operator-info will never be called up for community operator

@vimalk78 vimalk78 force-pushed the fix-must-gather-ns-1 branch from 6e82190 to 015d934 Compare January 29, 2024 14:31
vprashar2929
vprashar2929 previously approved these changes Jan 29, 2024
@vprashar2929
Copy link
Collaborator

It would be nice if we could address the previous issue with must-gather: #261 (comment)

KEPLER_OPERATOR_LABELS="operators.coreos.com/kepler-operator.openshift-operators"
POWER_MONITORING_OPERATOR_LABELS="operators.coreos.com/power-monitoring-operator.openshift-operators"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record I am okay with this but we need to address operator getting installed to ns other than openshift-operators (esp on 4.14+) in a different PR. Perhaps worth a bug @vprashar2929 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if that is really needed, lets do it in another PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, as already mentioned :-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, can we merge this?

@vimalk78 vimalk78 force-pushed the fix-must-gather-ns-1 branch 2 times, most recently from efa462c to 84caa6b Compare January 30, 2024 08:47
Signed-off-by: Vimal Kumar <vimal78@gmail.com>
@vimalk78 vimalk78 force-pushed the fix-must-gather-ns-1 branch from 84caa6b to 5820918 Compare January 30, 2024 08:49
@sthaha sthaha merged commit 683b6a1 into sustainable-computing-io:v1alpha1 Jan 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants