-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POWERMON-199: fix gather power-monitoring-operator info #353
POWERMON-199: fix gather power-monitoring-operator info #353
Conversation
6e7dca2
to
6e82190
Compare
get_catalogsource() { | ||
log "getting catalogsource info for kepler-operator" | ||
run oc -n "$KEPLER_OPERATOR_NS" get catalogsource kepler-operator-catalog -oyaml "$POWER_MONITORING_OPERATOR_INFO_DIR/kepler-operator-catalogsource.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we remove this as the operator would be from Red Hat certified Operators catalog source right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kept it for community operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but gather-power-monitoring-operator-info
will never be called up for community operator
6e82190
to
015d934
Compare
It would be nice if we could address the previous issue with must-gather: #261 (comment) |
KEPLER_OPERATOR_LABELS="operators.coreos.com/kepler-operator.openshift-operators" | ||
POWER_MONITORING_OPERATOR_LABELS="operators.coreos.com/power-monitoring-operator.openshift-operators" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record I am okay with this but we need to address operator getting installed to ns
other than openshift-operators
(esp on 4.14+) in a different PR. Perhaps worth a bug @vprashar2929 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if that is really needed, lets do it in another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, as already mentioned :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, can we merge this?
efa462c
to
84caa6b
Compare
Signed-off-by: Vimal Kumar <vimal78@gmail.com>
84caa6b
to
5820918
Compare
fix gather power-monitoring-operator info