Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve operator name capture in uninstall script #358

Merged

Conversation

vprashar2929
Copy link
Collaborator

This PR updates the uninstall script for capturing the operator name. The previous method was not optimal and was prone to error in cases where the user uninstalled any previous operator using UI. oc get operators will still show the operator being present.

For eg:

oc get subs -A ; oc get operators                                                           
NAMESPACE             NAME                             PACKAGE                          SOURCE             CHANNEL
openshift-operators   cluster-observability-operator   cluster-observability-operator   redhat-operators   development
NAME                                                 AGE
cluster-observability-operator.openshift-operators   59m
kepler-operator.openshift-operators                  27m
power-monitoring-operator.openshift-operators        9h

@vprashar2929 vprashar2929 requested a review from sthaha February 6, 2024 05:32
@vimalk78
Copy link
Collaborator

vimalk78 commented Feb 8, 2024

/lgtm

@sthaha sthaha marked this pull request as draft April 2, 2024 07:13
Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com>
@vprashar2929 vprashar2929 marked this pull request as ready for review April 3, 2024 08:53
@sthaha sthaha merged commit 0f31774 into sustainable-computing-io:v1alpha1 Apr 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants