feat: set availability to degraded when reconcile fails #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthaha
force-pushed
the
feat-degraded-availablilty
branch
from
3c2c6ff to
231f270
Compare
This commit adds a `Degraded` status. When reconcile fails, the status of the `available` condition is set to `Degraded`. The commit also fixes the LastTransitionTime to reflect actual last changed time that that latest time when any of the condition was updated. Signed-off-by: Sunil Thaha <sthaha@redhat.com>
sthaha
force-pushed
the
feat-degraded-availablilty
branch
from
231f270 to
9408c5f
Compare
vprashar2929
approved these changes
Mar 12, 2024
vprashar2929
merged commit 33ac756
into
sustainable-computing-io:v1alpha1
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
Degradedstatus. When reconcile fails, the statusof the
availablecondition is set toDegraded. The commit also fixesthe LastTransitionTime to reflect actual last changed time that that
latest time when any of the condition was updated.