feat: migrate operator code base to support new operator-sdk version #404
Conversation
vprashar2929
force-pushed
the
upgrade
branch
2 times, most recently
from
b98e8dd to
991afd8
Compare
vprashar2929
force-pushed
the
upgrade
branch
2 times, most recently
from
f1033fd to
f60dc51
Compare
| description: 'Deploys and Manages Kepler on Kubernetes ' | ||
| operators.operatorframework.io/builder: operator-sdk-v1.27.0 | ||
| operators.operatorframework.io/builder: operator-sdk-v1.34.2 |
There was a problem hiding this comment.
How about we move to 1.35 ?
There was a problem hiding this comment.
AFAIU we can opt-out the internal folder as all the controller code should be in the project root dir https://sdk.operatorframework.io/docs/building-operators/golang/migration/#controllers
Any thoughts?
There was a problem hiding this comment.
Lets not keep the controller internal. internal packages have special meaning - https://go.dev/doc/go1.4#internalpackages
bundle/tests/scorecard/config.yaml
Outdated
| @@ -8,7 +8,7 @@ stages: | |||
| - entrypoint: | |||
| - scorecard-test | |||
| - basic-check-spec | |||
| image: quay.io/operator-framework/scorecard-test:v1.25.1 | |||
| image: quay.io/operator-framework/scorecard-test:v1.34.2 | |||
hack/bundle.sh
Outdated
| @@ -58,7 +58,7 @@ main() { | |||
| info "Found old version: $old_bundle_version" | |||
|
|
|||
| info "Building bundle version $VERSION" | |||
| run operator-sdk generate kustomize manifests --apis-dir=./pkg/api --verbose | |||
| run operator-sdk generate kustomize manifests --apis-dir=./api --verbose | |||
There was a problem hiding this comment.
IIRC, api is the default dir. Could you please check?
vprashar2929
force-pushed
the
upgrade
branch
2 times, most recently
from
f6e9855 to
b15cc21
Compare
Dockerfile
Outdated
| # Copy must-gather scripts | ||
| COPY must-gather/ must-gather/ |
There was a problem hiding this comment.
lets preserve the order based on chance of modifying these files.
config/webhook/service.yaml
Outdated
|
|
||
| # selector: | ||
| # control-plane: controller-manager |
vprashar2929
force-pushed
the
upgrade
branch
2 times, most recently
from
83c66f7 to
4df0d0b
Compare
PROJECT
Outdated
| @@ -9,6 +13,7 @@ repo: github.com/sustainable.computing.io/kepler-operator | |||
| resources: | |||
| - api: | |||
| crdVersion: v1 | |||
| namespaced: true | |||
There was a problem hiding this comment.
this shouldn't marked as namespaced. Our APIs are cluster-scoped.
| @@ -3,7 +3,7 @@ kind: ServiceAccount | |||
| metadata: | |||
| labels: | |||
| app.kubernetes.io/name: serviceaccount | |||
| app.kubernetes.io/instance: controller-manager | |||
| app.kubernetes.io/instance: controller-manager-sa | |||
There was a problem hiding this comment.
Have you tested upgrade path with this? Will there be 2 SA after we upgrade ?
There was a problem hiding this comment.
When the Operator is upgraded it doesn't change the name of the SA as the name is fixed to controller-manager
This PR updates the code base for compatibility with the latest operator-sdk version(v1.35.0) Key Changes: * Moved API files from `pkg/api` to `api` folder * Relocated `main.go` from `cmd/manager/main.go` to `cmd/main.go` * Shifted controllers from `pkg/controllers` to `internal/controller` folder * Made minor updates to components, utils and tests to use correct import paths * Updated scaffolding config to align with the latest operator-sdk version * Revised Operator, bundle and e2e Dockerfiles * Upgraded operator-sdk to v1.35.0 and controller-gen to v0.13.0 * Updated bundle manifests accordingly Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com>
This PR updates the code base for compatibility with the latest operator-sdk version(v1.35.0)
Key Changes:
pkg/apitoapifoldermain.gofromcmd/manager/main.gotocmd/main.gopkg/controllerstocontrollersfolder