Feat: 771 remove unnecessary security concerns #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marceloamaral
requested changes
Sep 14, 2023
|
@BGrasnick would you mind if I took a stab at addressing the comments and submit another PR? |
|
Hey @sthaha! Sorry for the delay! I was away for a while but now I am back and ready to jump back in :) |
|
Thank you @BGrasnick , the PR is quite useful :) |
Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com>
Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com>
…n host PID namespace Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com>
Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com>
BGrasnick
force-pushed
the
feat/771-remove-unnecessary-security-concerns
branch
from
86af3c4 to
3587979
Compare
sthaha
reviewed
Oct 22, 2023
There was a problem hiding this comment.
@marceloamaral This PR looks good to me. Since you raised a concern which seems to be addressed, I will let you review and merge if it looks fine to you.
rootfs
approved these changes
Nov 1, 2023
rootfs
pushed a commit
to rootfs/kepler
that referenced
this pull request
Nov 13, 2023
…-io#926) * feat: reduce privileges granted through SCC for OpenShift Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com> * feat: set mounted volumes as read only as much as possible Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com> * feat: set pod hostPID to true to avoid collisions/unwanted behavior in host PID namespace Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com> * feat: remove unnecessary mount of /sys/kernel/debug Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com> --------- Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com>
vprashar2929
pushed a commit
to vprashar2929/kepler
that referenced
this pull request
Dec 19, 2023
…-io#926) * feat: reduce privileges granted through SCC for OpenShift Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com> * feat: set mounted volumes as read only as much as possible Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com> * feat: set pod hostPID to true to avoid collisions/unwanted behavior in host PID namespace Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com> * feat: remove unnecessary mount of /sys/kernel/debug Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com> --------- Signed-off-by: Bastien Grasnick <bastien.grasnick@deutschebahn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #771
Same improvements were already merged in the kepler-operator: sustainable-computing-io/kepler-operator#185
And the removal of the /sys/kernel/debug was discussed here: sustainable-computing-io/kepler-model-server#158 (comment)