Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#43 scroll position #52

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gitbreaker222
Copy link

@gitbreaker222 gitbreaker222 commented Jan 23, 2021

Before

Various use cases exist, where the scroll-position is not as expected - closes #43

After

A new method scrollToIndex is exposed to control the scroll-position from the consumer

This resolves following issues and PRs:

closes #15
closes #28
closes #30
closes #31 (PR)
closes #32
closes #60 (PR; similar to #15)

@gitbreaker222
Copy link
Author

gitbreaker222 commented Jan 23, 2021

looking at #44 I think I should keep the height map part and test with variable-height-items 🤔

edit: tested again and removed the fixed height: with and without the height-map part the scrollToItem method is unreliable. I think it is best to solve these things step by step:

  • scroll-position for lists with fixed-height-items
  • height-map for variable height items

VirtualList.svelte Outdated Show resolved Hide resolved
@gitbreaker222 gitbreaker222 force-pushed the #43_scroll-position branch from 86f8f4d to b834e77 Compare June 2, 2021 21:14
@BlueBomberman
Copy link

Hi! is this available already?

@gitbreaker222
Copy link
Author

gitbreaker222 commented Jun 9, 2021

@BlueBomberman Unfortunately I haven't got any response from Rich Harris on this since about 6 months. Maybe I can ping somebody else from the svelte team? Let's find out:

@Conduitry are you maybe able to review/merge/assign this PR? It would resolve 5 issues 1 other PR 🌟

edit 2021-06-18
or @pngwn maybe?

@stalkerg
Copy link

stalkerg commented Jul 5, 2021

@gitbreaker222 I suppose to make a fork will be much better in its current state.

@juancarrey
Copy link

I belive this may also fixes that if items are changed from the consumer (items filtered) the scroll position may out of range leaving the canvas empty.

@mellson
Copy link

mellson commented Jan 22, 2022

I would really love to see this PR merged if it's possible. Is there any way we can help this component going forward? Are you looking for active maintainers etc?

@gitbreaker222
Copy link
Author

community-edition package finally available. Thx again @mellson and sry for the long wait everyone
https://www.npmjs.com/package/svelte-virtual-list-ce

There will be some more upcoming changes to the readme and other maintenance stuff maybe :)

@gitbreaker222 gitbreaker222 deleted the #43_scroll-position branch January 23, 2022 14:12
@gitbreaker222 gitbreaker222 restored the #43_scroll-position branch February 1, 2022 08:43
@gitbreaker222 gitbreaker222 reopened this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants