-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#43 scroll position #52
base: master
Are you sure you want to change the base?
Conversation
looking at #44 I think I should keep the height map part and test with variable-height-items 🤔 edit: tested again and removed the fixed height: with and without the height-map part the
|
86f8f4d
to
b834e77
Compare
Hi! is this available already? |
@BlueBomberman Unfortunately I haven't got any response from Rich Harris on this since about 6 months. Maybe I can ping somebody else from the svelte team? Let's find out: @Conduitry are you maybe able to review/merge/assign this PR? It would resolve 5 issues 1 other PR 🌟 edit 2021-06-18 |
@gitbreaker222 I suppose to make a fork will be much better in its current state. |
I belive this may also fixes that if items are changed from the consumer (items filtered) the scroll position may out of range leaving the canvas empty. |
I would really love to see this PR merged if it's possible. Is there any way we can help this component going forward? Are you looking for active maintainers etc? |
community-edition package finally available. Thx again @mellson and sry for the long wait everyone There will be some more upcoming changes to the readme and other maintenance stuff maybe :) |
Before
Various use cases exist, where the scroll-position is not as expected - closes #43
After
A new method
scrollToIndex
is exposed to control the scroll-position from the consumerThis resolves following issues and PRs:
closes #15
closes #28
closes #30
closes #31 (PR)
closes #32
closes #60 (PR; similar to #15)