Show hint for UNC paths and images on hover

svsool · Jul 4, 2020 · eb3f636 · eb3f636
1 parent b870dcf
commit eb3f636
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/src/extensions/ReferenceHoverProvider.ts b/src/extensions/ReferenceHoverProvider.ts
@@ -8,6 +8,7 @@ import {
   isLongRef,
   getConfigProperty,
   getReferenceAtPosition,
+  isUncPath,
 } from '../utils';
 
 export default class ReferenceHoverProvider implements vscode.HoverProvider {
@@ -39,12 +40,20 @@ export default class ReferenceHoverProvider implements vscode.HoverProvider {
       });
 
       if (foundUri && fs.existsSync(foundUri.fsPath)) {
-        const fileContent = containsImageExt(foundUri.fsPath)
-          ? `![](${vscode.Uri.file(foundUri.fsPath).toString()}|height=${imagePreviewMaxHeight})`
-          : fs.readFileSync(foundUri.fsPath).toString();
+        const getContent = () => {
+          if (containsImageExt(foundUri.fsPath)) {
+            return `![${
+              isUncPath(foundUri.fsPath)
+                ? 'UNC paths are not supported for images preview due to VSCode Content Security Policy. Use markdown preview instead or open image via cmd (ctrl) + click.'
+                : ''
+            }](${vscode.Uri.file(foundUri.fsPath).toString()}|height=${imagePreviewMaxHeight})`;
+          }
+
+          return fs.readFileSync(foundUri.fsPath).toString();
+        };
 
         return new vscode.Hover(
-          fileContent,
+          getContent(),
           new vscode.Range(
             new vscode.Position(range.start.line, range.start.character + 2),
             new vscode.Position(range.end.line, range.end.character - 2),

diff --git a/src/utils/utils.ts b/src/utils/utils.ts
@@ -198,3 +198,7 @@ export const getFileUrlForMarkdownPreview = (filePath: string): string =>
 
 export const getImgUrlForMarkdownPreview = (imagePath: string): string =>
   `vscode-resource://${vscode.Uri.file(imagePath).toString().replace('file:', 'file')}`;
+
+const uncPathRegex = /^[\\\/]{2,}[^\\\/]+[\\\/]+[^\\\/]+/;
+
+export const isUncPath = (path: string): boolean => uncPathRegex.test(path);