-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed errors in placing confidential info #341
fixed errors in placing confidential info #341
Conversation
@swapnilsparsh review it, is working fine now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some bug errors while running your code, resolve them.
You need to install python-decouple module |
I have updated my branch with all latest changes in master, I guess it won't have any issues now
The issue is with the master branch, code is breaking there |
Resolve the conflicts |
I have updated my commits, have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error while running your code.
Resolve it
U were not in virtual env, activate your virtual env and pull the latest commit from my branch then try the same |
I have done the same still this error is showing. |
can u paste the last part of error message, it is not visible |
You need to add all variables that I mentioned in the .env file and also your google reCAPTCHA secret key too |
Done it already. |
I don't understand why you are getting those errors, everything is perfect from my side |
I am trying my level best to resolve the error as you have invested your time and hard work in this issue and due to some bug, it is not possible to merge the PR. |
can you reshare the last part of the error screenshot |
The photo which I shared with you above is the only error that I am getting and it's a full photo. |
Tried all these things but still issue didn't resolve. |
send me the bottom part of the error that you were getting after scrolling down to the bottom |
Already told you that the photo which I shared with you is the complete photo with error. |
You were not understanding what I meant, ok leave it trying deleting the codebase in this branch and pull it again |
Still showing the same error. |
@harshakhmk conflicts still exist. |
Btw which OS were you using @swapnilsparsh |
Windows |
Thank you @harshakhmk for your contribution. Looking forward for more such amazing contributions :) |
Related Issue or bug
Fixes: #292
Describe the changes you've made
Moved all the confidential information into environment variables and sending mail when the email and password provided by the host is Not None thereby reducing latency on the SMTPLIB server
Used python decouple module with version 3.4 to configure the environment variables
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)A clear and concise description of it.
Checklist:
Screenshots