fix(components): update mobile menu behaviour #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent on header preview" This reverts commit 8e664f6.
…dopdown-mobile-behavior-2
🦋 Changeset detectedLatest commit: 231fa8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
leagrdv
changed the title
|
Related Previews |
gfellerph
requested changes
Jan 10, 2025
| if (e.key === 'Tab') { | ||
| if (e.shiftKey && document.activeElement === this.firstFocusableEl) { | ||
| // If back tab (Tab + Shift) and first element is focused, focus goes to the last element of the megadropdown | ||
| e.preventDefault(); |
There was a problem hiding this comment.
This should only be done if the menu is open, otherwise it's impossible to go back to the logo and skiplinks:
Pressing [shift] + [tab] in this situation locks focus to the menu button.
3 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.