Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Updated dependencies for CmfMenuBundle 2.0 #28

Merged
merged 4 commits into from
Jan 7, 2016
Merged

Updated dependencies for CmfMenuBundle 2.0 #28

merged 4 commits into from
Jan 7, 2016

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Dec 14, 2014

No description provided.

@wouterj wouterj changed the title Updated dependencies for CmfMenuBundle 2.0 [WIP] Updated dependencies for CmfMenuBundle 2.0 Dec 14, 2014
@@ -13,7 +13,7 @@
"autoload": {
"psr-0": { "": "src/" }
},
"minimum-stability": "stable",
"minimum-stability": "dev",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should become stable once we release 1.3 (just like we did (or should have done) for the other releases).

"symfony-cmf/symfony-cmf": "1.2.*",
"symfony-cmf/simple-cms-bundle": "1.2.*",
"symfony-cmf/symfony-cmf": "dev-menu_2.0",
"symfony-cmf/simple-cms-bundle": "dev-menu_20",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these have to be updated once the PRs are merged

@wouterj
Copy link
Member Author

wouterj commented Dec 14, 2014

@lsmith77 lsmith77 added ready and removed in progress labels May 1, 2015
@lsmith77 lsmith77 added this to the 1.3 milestone Jun 17, 2015
@wouterj
Copy link
Member Author

wouterj commented Oct 29, 2015

This should also be ready to merge

@dbu dbu changed the title [WIP] Updated dependencies for CmfMenuBundle 2.0 Updated dependencies for CmfMenuBundle 2.0 Oct 29, 2015
@dbu
Copy link
Member

dbu commented Oct 29, 2015

tests fail with You have requested a non-existent service "doctrine_phpcr.admin.default_session".

@wouterj
Copy link
Member Author

wouterj commented Oct 29, 2015

@dbu yeah, for the same reason as symfony-cmf/cmf-sandbox#299 (comment) fails. This bug is fixed in doctrine/DoctrinePHPCRBundle#214, but it was not yet added to a release (1.3.0-RC2 is not yet released). This works for the bundles as they all rely on unstable versions, while the SE and sandbox rely on stable versions (at least more stable than dev).

@dbu
Copy link
Member

dbu commented Nov 12, 2015

i tagged the next RC now, but this still fails. so the regression is still open?

@wouterj
Copy link
Member Author

wouterj commented Nov 13, 2015

@dbu, no SE uses a composer.lock so you first have to update the deps locally, commit the lock file and push to this repo.

@dbu
Copy link
Member

dbu commented Nov 13, 2015

this is a new one:

Could not create database "/home/travis/build/symfony-cmf/standard-edition/app/app.sqlite" for connection named default

SQLSTATE[HY000] [14] unable to open database file

did something change on travis?

@wouterj
Copy link
Member Author

wouterj commented Nov 13, 2015

@dbu I got the same error on an app last week. Seems like a latest version of some package has a big bug causing this.

@dbu
Copy link
Member

dbu commented Nov 13, 2015

it looks like a travis file system permission problem :-(

@wouterj
Copy link
Member Author

wouterj commented Nov 13, 2015

@dbu no, it also happends locally on Windows (which does not know file system permissions like Travis does...)

@wouterj
Copy link
Member Author

wouterj commented Nov 13, 2015

@wouterj
Copy link
Member Author

wouterj commented Nov 13, 2015

Seems there already is a PR that fixes this: doctrine/DoctrineBundle#483

wouterj added a commit that referenced this pull request Jan 7, 2016
Updated dependencies for CmfMenuBundle 2.0
@wouterj wouterj merged commit c534e8c into master Jan 7, 2016
@wouterj wouterj deleted the menu_20 branch January 7, 2016 16:03
@wouterj wouterj removed the wip/poc label Jan 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants