-
Notifications
You must be signed in to change notification settings - Fork 157
Conversation
lsmith77
commented
May 12, 2014
Q | A |
---|---|
Doc fix? | yes |
New docs? | no |
Applies to | master, will need another commit for 1.1 |
Fixed tickets | #412 |
@@ -31,26 +31,19 @@ all of the required packages now. | |||
... | |||
"symfony-cmf/routing-auto-bundle": "1.0.*@alpha", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this even make sense to include this Bundle in a tutorial until its stable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @dantleech
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't simply remove it, as the tutorial is based on it being here. not sure how much is missing to tag a stable version of routing-auto?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well the tricky bit is .. does this even still work? even if it does today .. how long will it still work? if at all we need to set a fixed release here imho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for locking on a specific commit or alphaX tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's change it to a specific alpha tag.
It is indeed a bit tricky. To be honest, the whole tutorial is tricky. It is almost completely based on unstable features. On the other hand, it is one of the best parts of the docs for beginners currently. That's the reason it is in there.
We might want to check it and see what we get if we remove unstable features for the tutorial. Then we can keep the "old" tutorial in the dev
branch and merge it when the features are stable.
ok, then I propose we merge this and then create a follow up ticket to hardcode the routing-auto bundle dependency because the current dev-master is certainly even worse. |
remove dev master dependencies
ok follow up created #485 |