PHP7 Compatibility release #16
Conversation
|
wait for @nitriques to merge it |
extension.meta.xml
Outdated
| @@ -14,6 +14,9 @@ | |||
| </author> | |||
| </authors> | |||
| <releases> | |||
| <release version="1.7.2" date="2017-05-19" min="2.5.x" max="4.x.x" php-min="5.6.x" php-max="7.x.x"> | |||
There was a problem hiding this comment.
max should be "2.x.x", as "3.x.x" and "4.x.x" are allowed to introduce breaking changes.
extension.meta.xml
Outdated
| @@ -14,6 +14,9 @@ | |||
| </author> | |||
| </authors> | |||
| <releases> | |||
| <release version="1.7.2" date="2017-05-19" min="2.5.x" max="4.x.x" php-min="5.6.x" php-max="7.x.x"> | |||
There was a problem hiding this comment.
Where did you get php-min and php-max from? As far as I can tell, it's not part of the schema, or at least it’s not documented? http://symphonyextensions.com/schemas/extension/1.0/#changelogs-and-compatibility
There was a problem hiding this comment.
That's why the PR is not merged ;) It's a change @alexnantel88 added in her 4.0 experiment. But it is soooo nice, that I'd like to add it for real. I'll check with her if she can redo the PR, but without any of the "experimental" stuff. Thanks for the review tho ;)
There was a problem hiding this comment.
Nice. Just wasn’t sure if it was an undocumented new feature in 2.7 already.
There was a problem hiding this comment.
No no, I would not do that (voluntarily :P )
There was a problem hiding this comment.
Strange, I thought that php-min and php-max was a new "de-facto standard". I vaguely remember that we had a discussion about it, but unfortunately I don't remember where and when.
There was a problem hiding this comment.
@michael-e we agreed on this yes, but it was never implemented in an "official" way ;) I am still all for it !
There was a problem hiding this comment.
I am glad that you remember this — I was afraid that I only dreamed. :-)
Hmm, I already adopted it, e.g. here: michael-e/email_newsletter_manager@c396584
What should I do? Remove it? Or simply keep it?
There was a problem hiding this comment.
It should not create a problem (for the computer) to keep it. But if you want to be strict, it should not be there.
There was a problem hiding this comment.
@jensscherbl @nitriques
I've created a new branch (2.x) with the right release informations and removed the Symphony 4.x additions.
PHP true,false,null in lowercase SQL keywords uppercase
No description provided.