Merge pull request #42 from synyx/use-constructor-with-most-params

Use constructor with highest number of params instead of lowest

src/main/java/org/synyx/beanfiller/strategies/JustAnotherBeanStrategy.java

@@ -57,9 +57,10 @@ public Object createObjectInternal(ObjectInformation parentInformation) throws F
                 + " And we also could not find a constructor!");
         }
 
-        declaredConstructors.sort(Comparator.comparingInt(Constructor::getParameterCount));
-
-        Constructor declaredConstructor = declaredConstructors.get(0);
+        // use constructor with most parameters to potentially set the most final fields
+        Constructor declaredConstructor = declaredConstructors.stream()
+                .max(Comparator.comparingInt(Constructor::getParameterCount))
+                .orElse(null);
 
         try {
             declaredConstructor.setAccessible(true);

src/test/java/org/synyx/beanfiller/strategies/JustAnotherBeanStrategyTest.java

@@ -45,15 +45,15 @@ public void testNoDefaultConstructor() throws FillingException {
 
 
     @Test
-    public void testTakesTheConstructorWithTheLeastNumberOfParameters() throws FillingException {
+    public void testTakesTheConstructorWithTheHighestNumberOfParameters() throws FillingException {
 
         JustAnotherBeanStrategy strategy = setupStrategy();
 
         MultipleConstructorsObject object = (MultipleConstructorsObject) strategy.createObject(new ObjectInformation(
                     MultipleConstructorsObject.class, null, null, null, null, null));
         assertThat(object, notNullValue());
         assertThat(object.getFoo(), notNullValue());
-        assertThat(object.getBar(), nullValue());
+        assertThat(object.getBar(), notNullValue());
     }