alertmanager, revise regression test for link encoding

synyx · Nov 13, 2023 · de7c2c0 · de7c2c0
1 parent abe4e00
commit de7c2c0
Showing 1 changed file with 18 additions and 9 deletions.
diff --git a/pkg/connectors/alertmanager/connector_test.go b/pkg/connectors/alertmanager/connector_test.go
@@ -13,7 +13,7 @@ import (
 	"github.com/synyx/tuwat/pkg/connectors/common"
 )
 
-func TestConnector(t *testing.T) {
+func mockConnector() connectors.Connector {
 	testServer := httptest.NewServer(http.HandlerFunc(func(res http.ResponseWriter, req *http.Request) {
 		res.WriteHeader(http.StatusOK)
 		_, _ = res.Write([]byte(mockResponse))
@@ -27,7 +27,11 @@ func TestConnector(t *testing.T) {
 		},
 	}
 
-	var connector connectors.Connector = NewConnector(&cfg)
+	return NewConnector(&cfg)
+}
+
+func TestConnector(t *testing.T) {
+	connector := mockConnector()
 	alerts, err := connector.Collect(context.Background())
 	if err != nil {
 		t.Fatal(err)
@@ -36,13 +40,6 @@ func TestConnector(t *testing.T) {
 	if alerts == nil || len(alerts) != 3 {
 		t.Error("There should be alerts")
 	}
-
-	alert := alerts[0]
-	for _, link := range alert.Links {
-		if !strings.Contains(string(link), "://") {
-			t.Error("There should be a non encoded url")
-		}
-	}
 }
 
 func TestDecode(t *testing.T) {
@@ -53,6 +50,18 @@ func TestDecode(t *testing.T) {
 	}
 }
 
+func TestEncodingOfLinks(t *testing.T) {
+	connector := mockConnector()
+	alerts, _ := connector.Collect(context.Background())
+
+	alert := alerts[0]
+	for _, link := range alert.Links {
+		if !strings.Contains(string(link), "://") {
+			t.Error("There should be a non encoded url")
+		}
+	}
+}
+
 const mockResponse = `
 [
   {