Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake build under windows using NMake #109

Merged
merged 3 commits into from
Jul 27, 2023
Merged

CMake build under windows using NMake #109

merged 3 commits into from
Jul 27, 2023

Conversation

vasole
Copy link
Contributor

@vasole vasole commented Jun 28, 2023

Addresses #91

With these changes, the following instructions build SZ under windows with native MSVC compiler

mkdir build
cd build
cmake .. -G"NMake Makefiles"
nmake

@vasole
Copy link
Contributor Author

vasole commented Jun 28, 2023

I guess I can make first commit even more conservative (checking for windows without MINGW for instance).

Just let me now if you prefer so.

@disheng222
Copy link
Collaborator

Looks good to me. Thanks a lot for the effort.

Copy link
Collaborator

@robertu94 robertu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, it's good to have a Windows user contributing :) . A few things that need addressing:

sz/CMakeLists.txt Outdated Show resolved Hide resolved
zlib/CMakeLists.txt Show resolved Hide resolved
@vasole
Copy link
Contributor Author

vasole commented Jun 28, 2023

Since the check for windows without using MINGW was already used at other places, I have used that approach to resolve the concerns about 73065ab

@robertu94
Copy link
Collaborator

This looks good to me now @disheng222

@robertu94 robertu94 merged commit a92658e into szcompressor:master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants