Adding PDF Viewer sample #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding PDF Viewer sample to the Typescript samples. This PDF Viewer sample allows pdfs to be viewed using a dashboard network extension. It makes use of extension-apis around settings, dialogs, and parameters. The sample adds support for testing using jest and adding React components from tableau-ui. Adding support for tableau-ui requires React versions to match so had to move this project's react from 17.0.2 to 16.8.6. React-types didn't have a 16.8.6 version so went with the previous version of 16.8.5.
sarah-kim-tableau
approved these changes
Dec 19, 2024
stephendeoca
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding PDF Viewer sample to the Typescript samples. This PDF Viewer sample allows pdfs to be viewed using a dashboard network extension. It makes use of extension-apis around settings, dialogs, and parameters.
The sample adds support for testing using jest and adding React components from tableau-ui. Adding support for tableau-ui requires React versions to match so had to move this project's react from 17.0.2 to 16.8.6. React-types didn't have a 16.8.6 version so went with the previous version of 16.8.5.