Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache and cold storage retrieve the same content #37

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Cache and cold storage retrieve the same content #37

merged 1 commit into from
Feb 28, 2024

Conversation

brunocalza
Copy link
Contributor

This PR introduces the following changes:

  • The retrieve command behavior is modified so that the --output flag is expected to be a filename
  • When the CAR file is retrieved from cold storage, it is unpacked. That means both cache and cold storage should retrieve the same content

@brunocalza
make the cache and cold storage return the same content
42fada0 
Signed-off-by: Bruno Calza <brunoangelicalza@gmail.com>
@brunocalza brunocalza changed the title make the cache and cold storage return the same content Cache and cold storage retrieve the same content Feb 28, 2024
@brunocalza brunocalza marked this pull request as ready for review February 28, 2024 19:17
@brunocalza brunocalza self-assigned this Feb 28, 2024
dtbuchholz
dtbuchholz approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@dtbuchholz dtbuchholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 (and i can rebase my PR once we merge this to main)

@brunocalza brunocalza merged commit 6044303 into main Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtbuchholz dtbuchholz dtbuchholz approved these changes

Assignees

@brunocalza brunocalza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunocalza @dtbuchholz