Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list cache duration together with vault's name #41

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

brunocalza
Copy link
Contributor

@brunocalza brunocalza commented Mar 21, 2024

Summary

This PR changes the list command to use the /v2/vaults endpoint and return the cache duration together with vault's name.

Goes together with tablelandnetwork/basin-provider#31 and solves ENG-761

Signed-off-by: Bruno Calza <brunoangelicalza@gmail.com>
req, err := http.NewRequestWithContext(
ctx, http.MethodGet, fmt.Sprintf("%s/vaults/?account=%s", bp.provider, params.Account.Hex()), nil)
ctx, http.MethodGet, fmt.Sprintf("%s/v2/vaults/?account=%s", bp.provider, params.Account.Hex()), nil)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brunocalza
Copy link
Contributor Author

@dtbuchholz what do you think about the output of this one? essentially a table like this

+-------------+----------------+
|    VAULT    | CACHE DURATION |
+-------------+----------------+
| bruno2.test |                |
| bruno3.test |                |
| bruno4.test |                |
| a.a         |                |
| a.c         |                |
| a.d         |                |
| b.b         |           1000 |
| b.c         |                |
+-------------+----------------+

@dtbuchholz
Copy link
Contributor

@brunocalza lgtm! (and i'm assuming that it will work with --format json too)

@brunocalza brunocalza merged commit 6df00e0 into main Mar 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants