Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update readme with http api #43

Merged
merged 1 commit into from
Mar 28, 2024
Merged

docs: update readme with http api #43

merged 1 commit into from
Mar 28, 2024

Conversation

dtbuchholz
Copy link
Contributor

Summary

Adds HTTP API endpoints to the docs and makes a few small language tweaks.

@dtbuchholz dtbuchholz requested a review from brunocalza March 27, 2024 21:41
@@ -107,20 +117,24 @@ vaults account create [FILENAME]

A new private key will be written to `FILENAME`.

The name of a vault contains a `namespace` (e.g. `my_company`) and the name of an existing database relation (e.g. `my_table`), separated by a period (`.`). Use `vaults create` to create a new vault. See `vaults create --help` for more info.
The name of a vault contains a `namespace` (e.g. `my_company`) and an identifier (e.g., `my_data`), separated by a period (`.`). Use `vaults create` to create a new vault. See `vaults create --help` for more info.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if the namespace.identifier is the right way to define it, but i figured the "relation" nomenclature should be dropped.

vaults retrieve --output [FILENAME] bafybeifr5njnrw67yyb2h2t7k6ukm3pml4fgphsxeurqcmgmeb7omc2vlq
```

### HTTP APIs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added docs for HTTP APIs (I've been sharing a Notion doc, so i figured it'd best if it's just public)

Copy link
Contributor

@brunocalza brunocalza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@dtbuchholz dtbuchholz merged commit dccfea2 into main Mar 28, 2024
2 checks passed
@dtbuchholz dtbuchholz deleted the dtb/readme-http-api branch March 28, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants