Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

feat/fix: Large Book Update #118

Merged
merged 13 commits into from
Mar 19, 2024

Conversation

novusnota
Copy link
Member

Operators

A new and very detailed page. Every code block was tested for correctness.

Closes #59
Closes #62
Closes #64

Exit codes

Make a rather small clean-up and editing of the page, moved it to the Book. The real re-write is coming soon: tact-lang/tact#887.

Closes #107 (link is now working)

Compatibility with FunC

Cleaned up the formatting.

Closes #103 (as it happened to be the last place with incorrect spelling of Tact).

Statements

Re-wrote the page, added missing statements, moved some parts to operators page (and the upcoming expressions page)

Cookbook

Fixed links.

misc.

...and a lot more smaller changes here and there in the Book. Enjoy 🤘


As an aside, here's how operators section looked on the statements page:

image_2024-03-17_21-05-26

And here's how the dedicated operators page looks now:

image_2024-03-17_23-17-37

Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! The new info on operators is just great! I proposed some small fixes in the review comments

pages/book/composite-types.mdx Outdated Show resolved Hide resolved
pages/book/func.mdx Outdated Show resolved Hide resolved
pages/book/func.mdx Outdated Show resolved Hide resolved
pages/book/statements.mdx Outdated Show resolved Hide resolved
pages/book/statements.mdx Outdated Show resolved Hide resolved
pages/book/operators.mdx Outdated Show resolved Hide resolved
pages/book/operators.mdx Outdated Show resolved Hide resolved
pages/book/operators.mdx Show resolved Hide resolved
pages/book/operators.mdx Outdated Show resolved Hide resolved
pages/book/operators.mdx Outdated Show resolved Hide resolved
@novusnota
Copy link
Member Author

Added a bunch of fixes based on the feedback

anton-trunov
anton-trunov previously approved these changes Mar 18, 2024
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nits

pages/book/func.mdx Outdated Show resolved Hide resolved
pages/book/func.mdx Outdated Show resolved Hide resolved
pages/book/func.mdx Outdated Show resolved Hide resolved
pages/book/func.mdx Outdated Show resolved Hide resolved
pages/book/func.mdx Outdated Show resolved Hide resolved
@anton-trunov
Copy link
Member

Superb updates on possible error codes for the arithmetic ops and the semantics of bit shifting operations

novusnota and others added 5 commits March 18, 2024 20:01
Co-authored-by: Anton Trunov <anton.a.trunov@gmail.com>
Co-authored-by: Anton Trunov <anton.a.trunov@gmail.com>
Co-authored-by: Anton Trunov <anton.a.trunov@gmail.com>
Co-authored-by: Anton Trunov <anton.a.trunov@gmail.com>
@novusnota
Copy link
Member Author

@anton-trunov fixed nitpicks, thanks for your aid!

Co-authored-by: Anton Trunov <anton.a.trunov@gmail.com>
@anton-trunov anton-trunov merged commit 9341285 into tact-lang:main Mar 19, 2024
1 check passed
novusnota pushed a commit that referenced this pull request Mar 19, 2024
This is a follow-up PR on #118, using more augmented assignment operators in Tact docs
@novusnota novusnota deleted the 62+64+59-book-statements branch March 21, 2024 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants