feat: allow calling methods on null when self is of an optional type
#1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/types/resolveExpression.ts
Outdated
| } | ||
|
|
||
| // Return the only candidate | ||
| return registerExpType(ctx, exp, candidates[0]!.f.returns); |
There was a problem hiding this comment.
if (candidates.length === 0)
candidates[0]!
->
const candidate = candidates[0];
if (typeof candidate === 'undefined') { ... }
// now candidate is not falsy
There was a problem hiding this comment.
@verytactical have a look now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1283.
Checklist
docs/and made the build locally