Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --randomize-powerset feature #266

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

vi
Copy link
Contributor

@vi vi commented Jan 3, 2025

Resolves #265.

@taiki-e
Copy link
Owner

taiki-e commented Jan 25, 2025

Thanks for the PR! I'm positive on adding this feature. However:

  • CI is failing, so please fix that.
    • It should be able to be fixed by running cargo fmt and adding the words listed here to .github/.cspell/project-dictionary.txt.
  • Usually, I tend to choose fastrand over rand as a library for randomization unless rand is necessary for security reasons.

@taiki-e taiki-e added the A-features Area: features (--feature-powerset, --each-feature, etc.) label Jan 25, 2025
@vi
Copy link
Contributor Author

vi commented Jan 25, 2025

Is it a good idea to also add (in this PR) a pagination options (like --powerset-start-from=3000 --powerset-num-tests=1000) for splitting big scans over multiple invocations?

@taiki-e
Copy link
Owner

taiki-e commented Jan 25, 2025

As for the addition of other options, it would be easier to review if they were separated into separate PRs.

@vi
Copy link
Contributor Author

vi commented Jan 25, 2025

As for the addition of other options, it would be easier to review if they were separated into separate PRs.

Implemented as a continuation PR: vi#1

Note that for some reason it includes empty feature set case in each run.

README.md Outdated Show resolved Hide resolved
src/cli.rs Outdated Show resolved Hide resolved
tests/long-help.txt Outdated Show resolved Hide resolved
tests/short-help.txt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Randomizing order of trials in --feature-powerset
2 participants