-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(onboarding-wizard): adding support for ovhcloud #1226
base: develop
Are you sure you want to change the base?
feat(onboarding-wizard): adding support for ovhcloud #1226
Conversation
Hi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey folks apologies for delayed reviews I was caught up in something and the team is focussed in fixing the onboarding-wizard bug (we are still fixing).
Thanks @Kolawole99 for the PR. I have some minor nits. Maybe either we should remove the sublabels
or add something else. Also add a space in OVHCloud dashboard/utils/providerHelper.ts
@Kolawole99 any update? do you need help? |
@AvineshTripathi I would take a look at this, must have got lost in the notifications last year. |
@AvineshTripathi just for clarification that I got your nit correctly, the space should be in line komiser/dashboard/utils/providerHelper.ts Line 122 in 5e2fb7a
Also, can you clarify the issue with the |
for sublables i meant the text below the title like |
Problem
We intend to add OVHCloud support to the Onboarding Wizard.
As of now, other cloud providers are supported and can be configured through config.toml or the Onboarding Wizard, OVHCloud can only be configured through the config.toml file.
This handles GitHub issue #1213
This handles Linear ticket https://linear.app/tailwarden/issue/KOM-40
Solution
I added support for OVHCloud to the onboarding Wizard.
Changes Made
How to Test
Run a fresh install of Komiser which will trigger the Onboarding Wizard. Select OVH in the cloud account and click next, this should automatically route you to the OVH page to configure your credentials and submit to connect your OVH cloud accounts.
You can refer to the Screenshots above for a detailed demo of the process
Screenshots
[Include screenshots, if relevant, to help reviewers understand the changes you made.]
Notes
[Any additional notes or information that you would like to share with the reviewers.]
Checklist
Reviewers
@[username of the reviewer]