Skip Selects when Destination is cluster Redis #771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
RedisShake should panic instead of directly writing data from the other databses to db0, as this could lead to data corruption. The lua function feature can meet your needs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Syncing from Standalone Redis to Cluster Redis. if there is a select and set on the source redis, Redis-shake copies it to the destination irrespective of destination being cluster redis or not. Currently if such a situation arise syncing is stopped with this error:
2024-02-26 06:25:57 INF not set status port 2024-02-26 06:25:57 INF start syncing... 2024-02-26 06:25:57 ERR [writer_10.60.45.25_6379] receive reply failed. cmd=[select 2], error=[ERR SELECT is not allowed in cluster mode] RedisShake/internal/writer/redis_standalone_writer.go:111 -> (*redisStandaloneWriter).processReply()runtime/asm_amd64.s:1598 -> goexit()After these changes if destination is cluster, we won't change the dbId, instead directly run the respective command if destinaiton is a cluster.