Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies in taplo.toml #731

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rmburg
Copy link

@rmburg rmburg commented Jan 11, 2025

I took a look at the taplo.toml file of this repo to see an example of such a file, and noticed several inconsistencies within.

  • align_entries = true was inside a rule without any include or keys field, so I moved it to the global formatting table
  • the next rule had include and keys inside the formatting table, which is invalid.
  • I removed the keys field of this rule as well, as it does not currently work and prevents the rule from applying correctly. See reorder_arrays = false is ignored if the key is set to the array. #608
  • the next rule had include inside formatting as well
  • the last rule was not applied in the repo, and probably should not be applied: it asked to sort the keys in the package table inside Cargo.toml files
  • I moved align_comments to the Cargo.toml rule without a keys field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant