api: add more metrics #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-71-add-more-metrics
branch
from
24c977e to
b003731
Compare
Pull Request Test Coverage Report for Build 8388997461Details
💛 - Coveralls |
The module will help to save data in roles between reloads. The module is based on the crud[1] module with the same name. 1. https://github.com/tarantool/crud/blob/master/crud/common/stash.lua Part of #69
The commit moves storage-specific statistics into a file with another name to make clear its purpose. Part of #69
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-71-add-more-metrics
branch
from
b003731 to
9ad99b1
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-71-add-more-metrics
branch
5 times, most recently
from
f2bf6eb to
9e8b9ef
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-71-add-more-metrics
branch
2 times, most recently
from
e78b1e6 to
3a328e5
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-71-add-more-metrics
branch
from
3a328e5 to
f486257
Compare
* Metric `tnt_sharded_queue_api_role_stats` is a summary[1] with
quantiles of `sharded_queue.api` role API calls.
The metric includes a counter of API calls and errors.
The metric contains labels in the following format:
`{name = "tube_name", method = "api_call_method", status = "ok" or "error"}`
* Metric `tnt_sharded_queue_storage_role_stats` is a summary[1] with
quantiles of `sharded_queue.storage` role API calls.
The metric includes a counter of API calls and errors.
The metric contains labels in the following format:
`{name = "tube_name", method = "api_call_method", status = "ok" or "error"}`
* Metric `tnt_sharded_queue_storage_statistics_calls_total` as
an equivalent of `tnt_sharded_queue_api_statistics_calls_total`
for the `sharded_queue.storage` role.
Values have the same meaning as the `queue` statistics `calls`
table[2].
The metric contains labels in the following format:
`{name = "tube_name", state = "call_type"}`
* Metric `tnt_sharded_queue_storage_statistics_tasks` as an
equivalent of `tnt_sharded_queue_api_statistics_tasks` for
the `sharded_queue.storage` role.
Values have the same meaning as the `queue` statistics `tasks`
table[2].
The metric contains labels in the following format:
`{name = "tube_name", state = "task_state"}`
* Metric `sharded_queue_calls` renamed to
`tnt_sharded_queue_api_statistics_calls_total` The metric now has
labels in the format `{name = "tube_name", state = "call_type"}`
instead of `{name = "tube_name", status = "call_type"}`.
* Metric `sharded_queue_tasks` renamed to
`tnt_sharded_queue_api_statistics_tasks`. The metric now has labels
in the format `{name = "tube_name", state = "task_state"}` instead of
`{name = "tube_name", status = "task_state"}`.
1. https://github.com/tarantool/metrics/?tab=readme-ov-file#summary
2. https://github.com/tarantool/queue?tab=readme-ov-file#getting-statistics
Closes #69
Closes #71
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-71-add-more-metrics
branch
from
f486257 to
f887616
Compare
DifferentialOrange
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patchset adds:
tnt_sharded_queue_api_role_statsis a summary[1] with quantiles ofsharded_queue.apirole API calls. The metric includes a counter of API calls and errors. The metric contains labels in the following format:{name = "tube_name", method = "api_call_method", status = "ok" or "error"}tnt_sharded_queue_storage_role_statsis a summary[1] with quantiles ofsharded_queue.storagerole API calls. The metric includes a counter of API calls and errors. The metric contains labels in the following format:{name = "tube_name", method = "api_call_method", status = "ok" or "error"}tnt_sharded_queue_storage_statistics_calls_totalas an equivalent oftnt_sharded_queue_api_statistics_calls_totalfor thesharded_queue.storagerole. Values have the same meaning as thequeuestatisticscallstable[2]. The metric contains labels in the following format:{name = "tube_name", state = "call_type"}tnt_sharded_queue_storage_statistics_tasksas an equivalent oftnt_sharded_queue_api_statistics_tasksfor thesharded_queue.storagerole. Values have the same meaning as thequeuestatisticstaskstable[2]. The metric contains labels in the following format:{name = "tube_name", state = "task_state"}The patchset changes:
sharded_queue_callsrenamed totnt_sharded_queue_api_statistics_calls_totalThe metric now has labels in the format{name = "tube_name", state = "call_type"}instead of{name = "tube_name", status = "call_type"}.sharded_queue_tasksrenamed totnt_sharded_queue_api_statistics_tasks. The metric now has labels in the format{name = "tube_name", state = "task_state"}instead of{name = "tube_name", status = "task_state"}.Closes #69
Closes #71