URL encode username and password in RTSP URLs

tchellomello · Oct 6, 2023 · 95eb1e2 · 95eb1e2
1 parent 3c3fa58
commit 95eb1e2
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/amcrest/special.py b/src/amcrest/special.py
@@ -10,6 +10,7 @@
 # vim:sw=4:ts=4:et
 import logging
 import shutil
+import urllib.parse
 from typing import Optional
 
 from urllib3.exceptions import HTTPError
@@ -95,7 +96,10 @@ def _build_rtsp_url(
         else:
             port = ":{}".format(port_num)
 
-        return f"rtsp://{self._user}:{self._password}@{self._host}{port}/{cmd}"
+        username = urllib.parse.quote(self._user, safe='')
+        password = urllib.parse.quote(self._password, safe='')
+
+        return f"rtsp://{username}:{password}@{self._host}{port}/{cmd}"
 
     # pylint: disable=pointless-string-statement
     """