Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera.find_files() #221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix camera.find_files() #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/amcrest/media.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,26 @@ def factory_create(self) -> str:
return ret.content.decode()

def factory_close(self, factory_id: str) -> str:
ret = self.command(
f"mediaFileFind.cgi?action=factory.close&object={factory_id}"
)
try:
ret = self.command(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

f"mediaFileFind.cgi?action=close&object={factory_id}"
)
except:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use bare except:, it also catches unexpected events like memory errors, interrupts, system exit, and so on. Prefer except Exception:. If you're sure what you're doing, be explicit and write except BaseException:.
do not use bare 'except'

ret = self.command(
f"mediaFileFind.cgi?action=factory.close&object={factory_id}"
)

return ret.content.decode()

def factory_destroy(self, factory_id: str) -> str:
ret = self.command(
f"mediaFileFind.cgi?action=factory.destroy&object={factory_id}"
)
try:
ret = self.command(
f"mediaFileFind.cgi?action=destroy&object={factory_id}"
)
except:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use bare except:, it also catches unexpected events like memory errors, interrupts, system exit, and so on. Prefer except Exception:. If you're sure what you're doing, be explicit and write except BaseException:.
do not use bare 'except'

ret = self.command(
f"mediaFileFind.cgi?action=factory.destroy&object={factory_id}"
)
return ret.content.decode()

def media_file_find_start(
Expand Down