Skip to content

Commit

Permalink
fix: CI pipeline
Browse files Browse the repository at this point in the history
  • Loading branch information
jdreesen committed Oct 25, 2024
1 parent e56e392 commit eb088ea
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
1 change: 0 additions & 1 deletion .github/workflows/qa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]
workflow_dispatch:

permissions:
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]
workflow_dispatch:

permissions:
Expand All @@ -21,10 +20,13 @@ jobs:
include:
- php-version: "8.1"
dependencies: "lowest"
tests: --fail-on-risky
- php-version: "8.1"
dependencies: "highest"
tests: --fail-on-risky
- php-version: "8.2"
dependencies: "highest"
tests: --fail-on-risky

steps:
- name: Git Checkout
Expand All @@ -40,5 +42,9 @@ jobs:
with:
dependency-versions: ${{ matrix.dependencies }}

- name: Add Pimcore Admin UI
run: composer require --dev pimcore/admin-ui-classic-bundle --no-interaction
if: matrix.dependencies == 'highest'

- name: Execute tests
run: composer tests
run: composer tests -- ${{ matrix.tests }}
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"require-dev": {
"friendsofphp/php-cs-fixer": "^3.62",
"jangregor/phpstan-prophecy": "^1.0.2",
"laminas/laminas-zendframework-bridge": "^1.8",
"phpspec/prophecy-phpunit": "^2.2",
"phpstan/phpstan": "^1.11.10",
"phpstan/phpstan-phpunit": "^1.4",
Expand Down
1 change: 0 additions & 1 deletion phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
bootstrap="tests/bootstrap.php"
cacheResultFile=".phpunit.cache/test-results"
colors="true"
failOnRisky="true"
failOnWarning="true"
>
<php>
Expand Down

0 comments on commit eb088ea

Please sign in to comment.