-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Material-UI v4 and fix lint issues #83
base: master
Are you sure you want to change the base?
Conversation
@cvanem Moving the discussion to this PR now, but the errors should be fixed, I should probably clean up the proptype stuff I have commented out, but basically I caused a bunch of errors with some of the assumptions I made around default props being incorrect previously. Let me know what you need! |
Cleaned up the comments, let me know if I can do anything else! :) |
Quick feedback: None of the selections appear to be working.See items only and attempt to make a selection. Compared to current version. This isn't the only story, but one to look at Errors in consoleOutlined with custom adornments story shows these errors @BenDiuguid Thanks for getting this PR moving, and hope to merge it soon. @cvanem let me know if you see anything as well. When it looks good, I'll cut a prerelease to get some more testing in apps before an official release. |
@BenDiuguid @cvanem Getting this error in VSCode regarding the change in prettier to use babel instead of babylon.
Attempting to update all our dependencies (storybook especially) to clear up some console warnings about the old lifecycle methods... but it's going to need more work... I also needed to remove the old I'm not sure when I'll get more time to work on this... |
I'll take a look at this when I get some time, but sanity check question, did you I remember resolving the I'll double check running eslint from a clean yarn install when I get around to checking on the item selection issue. |
yarn storybook
locallyLet me know if I can fix up anything else! :)