Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expect to the make develop target #3413

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Add expect to the make develop target #3413

merged 1 commit into from
Jan 15, 2025

Conversation

psss
Copy link
Collaborator

@psss psss commented Dec 9, 2024

The expect package is needed for testing the tmt try features. Let's include it in the list of packages needed for development as well.

@psss psss added the code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. label Dec 9, 2024
Copy link
Collaborator

@skycastlelily skycastlelily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@lukaszachy lukaszachy added this to the 1.42 milestone Jan 15, 2025
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jan 15, 2025
The `expect` package is needed for testing the `tmt try` features.
Let's include it in the list of packages needed for development as
well.
@happz
Copy link
Collaborator

happz commented Jan 15, 2025

Minor change not affecting tests, merging.

@happz happz merged commit f101de9 into main Jan 15, 2025
12 of 20 checks passed
@happz happz deleted the expect branch January 15, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants