-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define a new context dimension for image mode #3423
base: main
Are you sure you want to change the base?
Conversation
Introduce a new context dimension key `*****-mode` in order to allow enabling/disabling/adjusting tests and plans based on the distribution mode.
Two versions were proposed/discussed on the stakeholder session let's review, discuss both (or brainstorm more) and vote/select the final candidate here. |
distro-mode | ||
Distribution mode, ``package`` for the standard way using | ||
packages or ``image`` for the new way of distributing | ||
using container images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vote here for distro-mode
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing it this. Do we really need to have two variables?
In my understanding distro-mode means installing packages in standard way, like RPM.
What about if user specifies:
distro-mode: true
image-mode: true
or opposite way:
distro-mode: false
image-mode: false
I would prefer to have only one variable like image-mode
that would be mean either image
or package
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that's the case, the question - and voting - is about "which one of these two dimensions?".
|
||
image-mode | ||
Flag denoting how new content is distributed. Use ``true`` | ||
for container images and ``false`` for standard packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vote here for image-mode
.
What about using an OS installation style instead? If I understood it correctly, "image mode" is basically just rpm-ostree ( https://docs.fedoraproject.org/en-US/fedora-silverblue/technical-information/ ) built in some special way. So for tests (or other software on the system), the difference is not "distro mode" vs "image mode", but the visible filesystem structure the test sees, ie. "FHS / standard" vs "rpm-ostree". The product name for that ("Atomic", "Silverblue", "image mode", .. ??) might be less relevant. edit: Note that I'm not super familiar with "image mode", some docs mention it's based on ostree, but not 100% compatible with it. |
@kkaarreell, as you raised this topic on the stakeholder session, do you have any specific use cases on mind for e.g. enabling / disable tests based on this new dimension? Are they possibly related to the filesystem structure the test sees as @comps mentioned above? |
Can the dimension name be |
Please don't. |
Yes, primarily test case filtering (enabling/disabling plans and tests). |
Introduce a new context dimension key
*****-mode
in order to allow enabling/disabling/adjusting tests and plans based on the distribution mode.Pull Request Checklist