Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract linter commands into their own module under tmt.cli #3433

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Extract linter commands into their own module under tmt.cli #3433

merged 1 commit into from
Jan 10, 2025

Conversation

happz
Copy link
Collaborator

@happz happz commented Dec 21, 2024

Part of the ongoing effort to shorten tmt.cli code.

Pull Request Checklist

  • implement the feature

@happz happz added code | cli Changes related to the command line interface code | style Code style changes not affecting functionality code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels Dec 21, 2024
@happz happz added this to the 1.41 milestone Dec 21, 2024
psss
psss approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@happz @psss
Extract linter commands into their own module under tmt.cli
fbba455 
Part of the ongoing effort to shorten tmt.cli code.
@psss psss added status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. ci | full test Pull request is ready for the full test execution labels Jan 10, 2025
@psss
Copy link
Collaborator

psss commented Jan 10, 2025

/packit test

@psss psss merged commit abbf907 into main Jan 10, 2025
20 checks passed
@psss psss deleted the split-cli-lint branch January 10, 2025 13:25
@psss psss self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therazix therazix therazix approved these changes

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution code | cli Changes related to the command line interface code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | style Code style changes not affecting functionality status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.41
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @psss @therazix