Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CentOS Stream 10 among test images #3435

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Add CentOS Stream 10 among test images #3435

merged 6 commits into from
Jan 22, 2025

Conversation

happz
Copy link
Collaborator

@happz happz commented Jan 2, 2025

Pull Request Checklist

  • implement the feature

@happz happz added code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. test coverage Improvements or additions to test coverage of tmt itself ci | full test Pull request is ready for the full test execution labels Jan 2, 2025
@happz happz added this to the 1.41 milestone Jan 2, 2025
@psss psss added the priority | should medium priority, should be included in the next release label Jan 7, 2025
@happz happz modified the milestones: 1.41, 1.42 Jan 13, 2025
@thrix thrix self-requested a review January 21, 2025 09:15
thrix
thrix approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz happz force-pushed the test-image-centos-stream-10 branch from 3cc0826 to f84b98a Compare January 21, 2025 13:15
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jan 21, 2025
psss
psss approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, otherwise looks good.

@psss psss force-pushed the test-image-centos-stream-10 branch from 187ef94 to 1994757 Compare January 22, 2025 09:20
@psss
Copy link
Collaborator

psss commented Jan 22, 2025

Tests were failing because epel-10 was not enabled in the testing copr repo. Should be fixed by 1994757.

@psss
Copy link
Collaborator

psss commented Jan 22, 2025

Heh, now it fails because of fedora-39:

Error: It wasn't possible to enable this project.
Repository 'fedora-39-x86_64' does not exist in project '@teemtee/stable'.

But that one is EOL, so I guess, that should be dropped?

@happz happz force-pushed the test-image-centos-stream-10 branch from 1994757 to eb398ab Compare January 22, 2025 12:08
@happz
Copy link
Collaborator Author

happz commented Jan 22, 2025

Heh, now it fails because of fedora-39:

Error: It wasn't possible to enable this project.
Repository 'fedora-39-x86_64' does not exist in project '@teemtee/stable'.

But that one is EOL, so I guess, that should be dropped?

I'm not sure about dropping the whole Fedora 39, that would require more changes, so for now I just disabled this Copr test in eb398ab.

@happz
Copy link
Collaborator Author

happz commented Jan 22, 2025

Rawhide will keep failing, I'm afraid.

@happz happz merged commit c58edf2 into main Jan 22, 2025
19 of 20 checks passed
@happz happz deleted the test-image-centos-stream-10 branch January 22, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@thrix thrix thrix approved these changes

@seberm seberm seberm approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. priority | should medium priority, should be included in the next release status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Milestone
1.42
Development

Successfully merging this pull request may close these issues.
4 participants
@happz @psss @seberm @thrix