Extend yamllint coverage to prepare/feature playbooks
#3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
code | no functional change
happz
requested review from
psss,
lukaszachy,
thrix,
janhavlin and
martinhoyer
as code owners
therazix
approved these changes
Jan 9, 2025
seberm
approved these changes
Jan 9, 2025
happz
added
the
status | ready for merge
psss
changed the title
psss
reviewed
Jan 14, 2025
psss
approved these changes
Jan 14, 2025
psss
force-pushed
the
extend-yamllint-to-prepare-feature-playbooks
branch
from
31ec64a to
55c9658
Compare
psss
changed the title
yamllint coverage to prepare/feature playbooks
These playbooks are not examples or test-only playbooks, but user-facing playbooks tmt and other tools may use in real workflows. They are covered by ansible-lint, let's add also yamllint to the mix because Ansible playbooks should be valid YAML files, and yamllint takes a slightly different view and reports slightly different set of issues. Whatever passes ansible-lint should be perfectly valid YAML file, but not necessarily nicely formatted, presentable, maintainable, readable, and/or consistent with the rest of playbooks shipped with tmt. yamllint should improve this side of the picture.
psss
force-pushed
the
extend-yamllint-to-prepare-feature-playbooks
branch
from
55c9658 to
bd3e2f3
Compare
|
Failures are irrelevant, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These playbooks are not examples or test-only playbooks, but user-facing playbooks tmt and other tools may use in real workflows. They are covered by ansible-lint, let's add also yamllint to the mix because Ansible playbooks should be valid YAML files, and yamllint takes a slightly different view and reports slightly different set of issues. Whatever passes ansible-lint should be perfectly valid YAML file, but not necessarily nicely formatted, presentable, maintainable, readable, and/or consistent with the rest of playbooks shipped with tmt. yamllint should improve this side of the picture.
Pull Request Checklist