Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement --dry for mrack plugin #3460

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Implement --dry for mrack plugin #3460

merged 6 commits into from
Jan 28, 2025

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented Jan 10, 2025 •
edited by psss
Loading

Pull Request Checklist

  • implement the feature

@skycastlelily skycastlelily mentioned this pull request Jan 10, 2025
Closed
@skycastlelily skycastlelily added the ci | full test Pull request is ready for the full test execution label Jan 13, 2025
@skycastlelily skycastlelily added this to the 1.42 milestone Jan 13, 2025
psss
psss reviewed Jan 14, 2025
View reviewed changes
tmt/steps/provision/mrack.py Outdated Show resolved Hide resolved
happz
happz reviewed Jan 20, 2025
View reviewed changes
tmt/steps/provision/mrack.py Outdated Show resolved Hide resolved
@thrix thrix requested review from psss and happz January 21, 2025 01:21
thrix
thrix requested changes Jan 21, 2025
View reviewed changes
tmt/steps/provision/mrack.py Outdated Show resolved Hide resolved
happz
happz reviewed Jan 21, 2025
View reviewed changes
tmt/steps/provision/mrack.py Outdated Show resolved Hide resolved
@thrix thrix requested review from happz and thrix January 27, 2025 15:43
@thrix thrix self-requested a review January 27, 2025 18:17
thrix
thrix approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thrix thrix added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jan 27, 2025
psss
psss approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for implementing this! Just removed the first line indent in 15d2bbb.

@thrix thrix enabled auto-merge (squash) January 28, 2025 13:00
@lukaszachy lukaszachy linked an issue Jan 28, 2025 that may be closed by this pull request
Implement --dry for the beaker provision plugin #3456
Closed
@thrix
Copy link
Collaborator

thrix commented Jan 28, 2025

/packit retest-failed

@thrix thrix disabled auto-merge January 28, 2025 16:12
@thrix thrix merged commit d6b644e into main Jan 28, 2025
19 of 20 checks passed
@thrix thrix deleted the dry-mrack branch January 28, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@psss psss psss approved these changes

@thrix thrix thrix approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.42
Development

Successfully merging this pull request may close these issues.

Implement --dry for the beaker provision plugin
4 participants
@skycastlelily @thrix @happz @psss