Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract tmt * export from tmt.cli into standalone module #3461

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Extract tmt * export from tmt.cli into standalone module #3461

wants to merge 1 commit into from

Conversation

happz
Copy link
Collaborator

@happz happz commented Jan 13, 2025

Pull Request Checklist

  • implement the feature

@happz happz added code | cli Changes related to the command line interface code | style Code style changes not affecting functionality code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels Jan 13, 2025
@happz happz added this to the 1.42 milestone Jan 13, 2025
thrix
thrix approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thrix thrix force-pushed the tmt-cli-extract-export branch from 0881cd8 to 14f3e0e Compare January 21, 2025 01:20
@thrix thrix enabled auto-merge (rebase) January 21, 2025 01:20
@happz happz added the ci | full test Pull request is ready for the full test execution label Jan 21, 2025
@happz
Copy link
Collaborator Author

happz commented Jan 21, 2025

/packit build

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jan 21, 2025
@psss psss changed the title Extract tmt * export from tmt.cli into standalone module Extract tmt * export from tmt.cli into standalone module Jan 21, 2025
@psss
Copy link
Collaborator

psss commented Jan 21, 2025

The /requre/polarion test seems to be failing with:

Error: No such command 'export'.

@happz, could you please have a look?

@happz happz modified the milestones: 1.42, 1.43 Jan 21, 2025
@psss psss removed the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therazix therazix therazix approved these changes

@psss psss psss approved these changes

@thrix thrix thrix approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution code | cli Changes related to the command line interface code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | style Code style changes not affecting functionality
Projects
None yet
Milestone
1.43
Development

Successfully merging this pull request may close these issues.
4 participants
@happz @psss @thrix @therazix