Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible double normalization of hardware field #3462

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

happz
Copy link
Collaborator

@happz happz commented Jan 13, 2025

It seems to happen in the very simple workflow, e.g. tmt run discover plan --name '...'.

Pull Request Checklist

  • implement the feature

@happz happz added bug Something isn't working step | provision Stuff related to the provision step labels Jan 13, 2025
@happz happz added this to the 1.41 milestone Jan 13, 2025
@happz happz added the ci | full test Pull request is ready for the full test execution label Jan 13, 2025
@happz happz force-pushed the hardware-double-normalize branch 2 times, most recently from c04882e to b7cf102 Compare January 13, 2025 15:59
@psss psss added the area | hardware Implementation of hardware requirements label Jan 13, 2025
@psss psss requested a review from bajertom January 13, 2025 16:16
Copy link
Collaborator

@bajertom bajertom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

It seems to happen in the very simple workflow, e.g. `tmt run discover plan --name '...'`.
@happz happz force-pushed the hardware-double-normalize branch from b7cf102 to 8ae0ead Compare January 13, 2025 17:49
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jan 13, 2025
@psss psss self-assigned this Jan 13, 2025
@psss
Copy link
Collaborator

psss commented Jan 13, 2025

Everything was green before the rebase, changes in unrelated area, merging.

@psss psss merged commit 90b8ddf into main Jan 13, 2025
12 of 20 checks passed
@psss psss deleted the hardware-double-normalize branch January 13, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area | hardware Implementation of hardware requirements bug Something isn't working ci | full test Pull request is ready for the full test execution status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. step | provision Stuff related to the provision step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants